search

qiskit-community / qiskit-qcgpu-provider

A provider which allows Qiskit to use the QCGPU simulator
http://qcgpu.github.io/
Apache License 2.0
25 stars 12 forks source link

suggestion for test for state vector #5

Closed jaygambetta closed 5 years ago

jaygambetta commented 5 years ago

I would not test the state vector to the absolute values of each term. In quantum global phase does not matter. We made in qiskit a state_fedility which you could use and if it is equal to one then it is the same state.

I know this does not matter too much for now but I could imagine you optimizing for global phase at some point.

It could also be good to have a test that compares the outcomes of random circuits from BasicAer and your statevector simulator.

adamisntdead commented 5 years ago

Good idea, I will look at that

adamisntdead commented 5 years ago

This was implemented, closing.