search

qiskit-community / qiskit-quantinuum-provider

Qiskit provider for Quantinuum backends.
Apache License 2.0
21 stars 17 forks source link

Initial implementation of Honeywell provider #1

Closed dan1pal closed 4 years ago

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

ajavadia commented 4 years ago

Given this is being merged into the Qiskit project I think it needs the Qiskit copyright, in addition to the Honeywell one. They can both exist on each file. Both are Apache 2.0

dan1pal commented 4 years ago

Given this is being merged into the Qiskit project I think it needs the Qiskit copyright, in addition to the Honeywell one. They can both exist on each file. Both are Apache 2.0

@ajavadia, can you please confirm that this is a strict requirement? I have not come across it before. It will cause some more work to clear.

ajavadia commented 4 years ago

@dan1pal yes since this is hosted in the Qiskit github org, the Qiskit copyright must exist, but it can be next to the current one.

dan1pal commented 4 years ago

@dan1pal yes since this is hosted in the Qiskit github org, the Qiskit copyright must exist, but it can be next to the current one.

To clarify further, does this mean the addition of the following line to each file?

# This code is part of Qiskit.
ajavadia commented 4 years ago

Yes I mean adding the full copyright (not just that one line) to all files, in addition to Honeywell's own.

See an example here where a file was copied from QuTiP to Qiskit: https://github.com/Qiskit/qiskit-terra/blob/2fe505541114747494e5a6ba7a57c77878cda069/qiskit/visualization/bloch.py