search

qitab / cl-protobufs

Common Lisp protocol buffer implementation.
MIT License
84 stars 18 forks source link

Fix map field type error when value type is defined after the map #186

Closed bkuehnert closed 4 years ago

bkuehnert commented 4 years ago

This fixes bug #181 and adds tests for the bug. With this change, now NIL can be inserted into maps that have message values. This is a bug, but it is the same behavior as any optional message field.

Slids commented 4 years ago

Please don't make titles like: Fix bug #181 #186 I have no idea what bug 181 is, instead say what it's doing and then link to the bug in the description.

bkuehnert commented 4 years ago

Please don't make titles like: Fix bug #181 #186 I have no idea what bug 181 is, instead say what it's doing and then link to the bug in the description.

Edited it. The bug is a bit of a mouthful, hence why I linked it

Slids commented 4 years ago

Should this also update the json code? Or is that in another cl?

bkuehnert commented 4 years ago

Should this also update the json code? Or is that in another cl?

What would change in the JSON code?

Slids commented 4 years ago

You commented out several well known types.

Slids commented 4 years ago

I see, this is cl-protobufs should import struct.proto #182 nvm For some reason I thought this and that were related...

bkuehnert commented 4 years ago

I see, this is cl-protobufs should import struct.proto #182 nvm For some reason I thought this and that were related...

Oh right, I understand. That's next :)

Slids commented 4 years ago

merged as of https://github.com/qitab/cl-protobufs/commit/27d33c63b1516662e43e633fad15728d2034bebd