Closed copybara-service[bot] closed 3 years ago
Fix map field has- function.
Currently we use an isset bit to determine if a map is being used in a proto message. This is a) Wasteful, just check if it has an element. b) Wrong, we fail to always change the bit properly.
Instead just check if the map has any entries
Fix map field has- function.
Currently we use an isset bit to determine if a map is being used in a proto message. This is a) Wasteful, just check if it has an element. b) Wrong, we fail to always change the bit properly.
Instead just check if the map has any entries