qitab / cl-protobufs

Common Lisp protocol buffer implementation.
MIT License
78 stars 17 forks source link

use enum name as constant prefix #364

Open jidibinlin opened 2 years ago

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Slids commented 2 years ago

I like the idea, but you a) Need to sign the cla b) fix the tests (sadly not the ABCL test, there's something going on I haven't figured out) c) We need to make an anouncement as this is a breaking change.

jidibinlin commented 2 years ago

I will find a time to solve this issue

jidibinlin commented 2 years ago

I have fixed the enum-mapping-test.lisp file。 But still can`t pass all the test。

image