qitab / cl-protobufs

Common Lisp protocol buffer implementation.
MIT License
78 stars 17 forks source link

consider add descriptor.proto? #370

Closed jidibinlin closed 1 year ago

Slids commented 1 year ago

It would take quite a bit of work to do it properly. Not a bad idea, but something I'd probably give a low priority, medium effort, low return rating.

Do you have a reason for wanting it?

Slids commented 1 year ago

Unless you mean literally just adding the proto file to this repo?

jidibinlin commented 1 year ago

I have a proto file need to import descriptor.proto。buf if cl-protobufs didn`t load descriptor.proto, I have no idea to load my proto file in my project。

what i need is add descripor.proto to cl-protobufs well-known-types module like cl-protobufs/test did

Slids commented 1 year ago

You have other proto files in your project, so just add it to your project? We have plenty examples of loading proto files in cl-protobufs.asd.

jidibinlin commented 1 year ago

@Slids But cl-protobufs already copied the descriptor.proto to google/protobufs/ directory。

Slids commented 1 year ago

So we were talking about too kinda different things, I was overthinking things. So the ask is to add a module "descriptor" with protobuf-source-file "descriptor"?

jidibinlin commented 1 year ago

@Slids Yes.

Slids commented 1 year ago

Done.