search

qitab / cl-protobufs

Common Lisp protocol buffer implementation.
MIT License
76 stars 17 forks source link

Support newer versions of protobuf #434

Open Partmedia opened 3 months ago

Partmedia commented 3 months ago

This library doesn't compile with newer versions of protobuf (see https://github.com/qitab/cl-protobufs/issues/402), because some functions have been moved/renamed.

After I completed this patch, I realized that this duplicates efforts that already exist:

But this is all tidy and in a smaller and more manageable diff. Ultimately because this is a Google library you might opt to close this PR and merge those others instead :)

fixes #402

Slids commented 3 months ago

I'm happy, but the workflows are not.

Slids commented 3 months ago

Sorry, sick, sick kids, non-fun times.

Partmedia commented 3 months ago

I'll investigate now that the workflow has been run, hopefully it'll automatically re-run when I push to the branch.

Based on the output fingers crossed that I'm just missing #include <abseil.h> or something.

Slids commented 2 weeks ago

It's been on my list to do, but the open source bit of cl-protobufs is me, @cgay helps out but he's no longer at Google, and our team is... smaller (see news...)

This does not pass SBCL or CCL, I don't care about ABCL atm.