greenkeeper[bot] commented 7 years ago

Version 12.0.0 of should just got published.

Dependency	should
Current Version	11.2.1
Type	devDependency

The version 12.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of should. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Release Notes

Better Map Set equality

Map/Set/WeakMap/WeakSet equality checks

User @BridgeAR pointed to a number of bugs and inconcistency in Map/Set/WeakMap/WeakSet checks. To fix all this things, i switched map and set equality checks to do key checks defined in standard instead of value checks.
Typical example that was working before this release:

const m1 = new Map([[{ a: 1 }, 11]]);
const m2 = new Map([[{ a: 1 }, 11]]);

m1.should.be.eql(m2)

And not this example is breaking. At first view it is a bit unclear why it should not be so. Consider another example:

const m1 = new Map([[{}, 11], [{}, 12]]);
const m2 = new Map([[{}, 11], [{}, 12]]);

m1.should.be.eql(m2)

This example is not that clear if it should assert or not, right? (it should).

As Map and Set (as their weak equavalents) allows to use any type value/ref as key, perfectly equal by value (what should.js do) {} and {} is not equal by reference. In should.js i am always trying to limit users to do not shoot themselfs in their foots and just do right thing if possible and when possible. That is why both examples will throw assertions starting 12.0.0.

Consistency in bundles

For the long time (probably several years now) browser bundle and node bundle has little differences in globals.
To make them sync i am doing such changes to bundles:

Browser bundle will not contain window.Should any more (with capital S). It was deprecated for the long time. Just use window.should as is.
Node bundle change global.should to be should function instead of getter attached to Object.prototype.

Commits

The new version differs by 12 commits.

52dc121 Release 12.0.0
6c1e6bd Prettier all
6114e76 Update years
670df30 Merge branch 'master' of github.com:shouldjs/should.js
ecf8033 Update tools
e4d0acc Normalize entry points
f4adabb Set zuul to use 2 last versions of browsers
8114b5d Merge pull request #143 from isayme/issue/aboveOrEqual-belowOrEqual
02ec6a0 fix error message for aboveOrEqual & belowOrEqual
031888e Merge pull request #140 from carldunham/feature/cd/add-equals-eqls
1e4909b Add for readability: equals, eqls
4a53d94 Release 11.2.1

See the full diff

Not sure how things should work exactly?

There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

codecov-io commented 7 years ago

Codecov Report

Merging #72 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files           4        4           
  Lines          44       44           
=======================================
  Hits           41       41           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e212a86...22fb107. Read the comment docs.

greenkeeper[bot] commented 7 years ago

Version 13.0.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 11 commits.

b9bf8ff Release 13.0.0
c8a5851 Remove ignored file
ebfdd19 Travis uses node 8
92d0db1 Remove bower, as it seems nobody uses it
fe1ae5c Fix shouldjs/should.js#150
c4924be Fix build and restore old files. In a bit silly way, but it works.
c946259 Fix tests
90bf91e Prettier everything
999b122 Add first version of TS typings for should.js
06062c5 Reorganize build
c50e66a Disable package-lock.json because i am controlling all dependencies

See the full diff

greenkeeper[bot] commented 7 years ago

Version 13.0.1 just got published.

Update to this version instead 🚀

Release Notes

13.0.1

Add back missing umd build in root of package

Commits

The new version differs by 2 commits.

e90c2cf Release 13.0.1
789b8cf Add missing umd bundle

See the full diff

greenkeeper[bot] commented 7 years ago

Version 13.1.0 just got published.

Update to this version instead 🚀

Release Notes

13.1.0

New

Now all zero argument assertions throw TypeError in case any argument passed to them.
Aliased .fulfill/.fulfilledWith to .resolve/.resolvedWith`

Fixes

TS definition fixed to allow such imports:

import should from 'should';

Commits

The new version differs by 6 commits.

c807e9d Release 13.1.0
8acfba1 Merge pull request #154 from citizensas/master
c12afd0 chore: should has no default export
4a846b1 Fill history
f5c9cc3 Added check for zero argument assertions.
fe6b136 Added .resolved, .resolvedWith as aliases to .fulfilled, .fulfilledWith