search

qiuzijian / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

comparison between signed and unsigned integer expressions in MinidumpFileWriter::Copy #393

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
https://bugzilla.mozilla.org/show_bug.cgi?id=587581

What steps will reproduce the problem?
1. build breakpad

What is the expected output?
no warnings about comparison between signed and unsigned integer expressions

What do you see instead?
google-breakpad/src/client/minidump_file_writer.cc:
 In member function ‘bool google_breakpad::MinidumpFileWriter::Copy(MDRVA, const void*, ssize_t)’:
238: warning: comparison between signed and unsigned integer expressions

What version of the product are you using?
trunk

On what operating system?
OS X

Please provide any additional information below.
write() is a funny function, it takes a size_t as an argument but returns a 
ssize_t (which means it's more or less broken). There are two copy methods in 
breakpad, one takes a size_t, and one takes a ssize_t, and one seems to call 
the other...

Original issue reported on code.google.com by timel...@gmail.com on 16 Aug 2010 at 8:57

Attachments: