search

qiuzijian / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

linux_dumper_unittest VerifyStackReadWithMultipleThreads is flaky #403

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. run it on a very heavily loaded system.

What is the expected output? What do you see instead?
Tests pass

Instead I see

[ RUN      ] LinuxDumperTest.VerifyStackReadWithMultipleThreads
src/client/linux/minidump_writer/linux_dumper_unittest.cc:105: Failure
Value of: dumper.threads().size()
  Actual: 1
Expected: (size_t)kNumberOfThreadsInHelperProgram
Which is: 5
[  FAILED  ] LinuxDumperTest.VerifyStackReadWithMultipleThreads (1301 ms)

What version of the product are you using? On what operating system?
598, though the source is written making an assumption on progress of the 
separate linux_dumper_unittest_helper in 1s of wall clock time which still 
exists as of 762.

Please provide any additional information below.

Original issue reported on code.google.com by kmix...@chromium.org on 15 Sep 2010 at 10:05

GoogleCodeExporter commented 9 years ago 
I fixed this in r741, I made the parent process wait for a write on a pipe fd 
from the child process. (It uses poll so it won't hang forever if the child 
fails for some reason.)

Original comment by ted.mielczarek on 15 Dec 2010 at 1:59