search

qiwi / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
86 stars 34 forks source link

fix: bump release type by dependent if deps.release is inherit #100

Closed gavmck closed 1 month ago

gavmck commented 3 months ago

Changes

When deps.release is set to inherit, but a package has changes, it overwrites the release type from the dependent package, even if the release type was greater (patch < minor < major).

This updates the resolveRelesaseType function so that if a dependent package has a larger version bump and deps.release is set to inherit, we'll take the inherited release type instead of the lesser local package one.

Test scenario: I had a major version bump in one of my packages that all other packages are dependent on and the dependent packages were only doing a minor update because they had local changes.

antongolub commented 3 months ago

Hey, @gavmck,

Could you add a test for the fix?

gavmck commented 3 months ago

Hey, @gavmck,

Could you add a test for the fix?

Sure thing, I'll drop some in shortly

gavmck commented 1 month ago

@antongolub Sorry, I know this has taken ages! Patched up feedback and added a test 👍

qiwibot commented 1 month ago

:tada: This PR is included in version 7.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: