search

qiwi / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
86 stars 34 forks source link

Wrong version of local dependencies in pre-release branch #25

Closed zlatanpham closed 3 years ago

zlatanpham commented 3 years ago

Hi guys, I'm testing msr and it seems there is an issue with a pre-release branch where a local dependency does not point to the right version. Seeing the attachment, the beta suffix is truncated.

Any idea if it is a bug?

Screen Shot 2020-12-23 at 3 18 00 PM

oljekechoro commented 3 years ago

Hi! We have not tested this case yet, we will try to do it till the end of week

zlatanpham commented 3 years ago

Hi! We have not tested this case yet, we will try to do it till the end of week

That'd be nice. Cheers!

davikawasaki commented 3 years ago

I have forked and created a feature to cover this. I'll be sending a PR in a bit.

qiwibot commented 3 years ago

:tada: This issue has been resolved in version 3.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

oljekechoro commented 3 years ago

@davikawasaki @zlatanpham, thanks a lot for your help. Your issues and pull requests are important for us.

zlatanpham commented 3 years ago

Hey @davikawasaki @oljekechoro, I just had a quick test with the new version and it seems the issue was not completely resolved. The beta suffix is now available but the version is incorrect. The screenshot to capture the issue is attached below but the details can be found here.

Screen Shot 2020-12-24 at 1 16 01 PM