search

qiwi / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
86 stars 34 forks source link

Bug: package.json contains incorrect deps versions #27

Open antongolub opened 3 years ago

antongolub commented 3 years ago

Hey @davikawasaki @oljekechoro, I just had a quick test with the new version and it seems the issue was not completely resolved. The beta suffix is now available but the version is incorrect. The screenshot to capture the issue is attached below but the details can be found here.

Screen Shot 2020-12-24 at 1 16 01 PM

Originally posted by @zlatanpham in https://github.com/qiwi/multi-semantic-release/issues/25#issuecomment-750764078

antongolub commented 3 years ago

@zlatanpham,

Looks very similar to https://github.com/dhoulb/multi-semantic-release/issues/47. At first we will try to localize the problem. Stay tuned.

davikawasaki commented 3 years ago

@antongolub don't know if you have fixed this yet, but it seems like the way we bump local dependencies is different from the way we bump the package. Maybe we should standardize it... How are we bumping the main package (i.e. packages/apple) to 12.0.0-beta.1?

antongolub commented 3 years ago

I agree, there is a rather confusing piece. Any ideas how this could be improved?

davikawasaki commented 3 years ago

@antongolub I'll tinker on this through these holidays days and I'll let you know.

antongolub commented 3 years ago

@zlatanpham, @Ellosaur

The fix is ready for testing (v3.12.2, many thanks to @davikawasaki). Could you take a look and give feedback?

Ellosaur commented 3 years ago

@antongolub as we're using "multi-semantic-release": "^2.5.3" in our project can we simply hot swap to "@qiwi/multi-semantic-release": "3.12.2" or should we wait until the fix makes it upstream to dhoulb/multi-semantic-release?

antongolub commented 3 years ago

@Ellosaur,

As you wish. @qiwi-scoped msr is just like a canary build channel.

Ellosaur commented 3 years ago

Our first release since switching has upgraded the changelog and dependencies correctly. However the second release exhibited the familiar problem: image

antongolub commented 3 years ago

@Ellosaur,

Could you show .releaserc? I need to know what plugins are used to observe how they modify package.json files.

Ellosaur commented 3 years ago

@antongolub,

Sure. We use the release section in the packages.json rather than a .releaserc. I included these on the original issue I logged dhoulb#47. Those settings haven't changed.

Ellosaur commented 3 years ago

FYI we're now using semantic-release-monorepo which doesn't attempt to update package references so it avoids this problem. We leave references as ~1.x so that the latest package is always referenced