search

qiwi / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
86 stars 34 forks source link

Feat: ignore packages to be released with workspaces and CLI #42

Closed davikawasaki closed 3 years ago

davikawasaki commented 3 years ago

Solves #37. I've also replaced bash-glob with node-glob, but I'm up for suggestions.

antongolub commented 3 years ago

Hey, @davikawasaki

That's really impressive. I need some time to review it. Could you resolve the merge conflict for now?

davikawasaki commented 3 years ago

@antongolub Which merge conflict? In here says that the branch has no conflicts with the base branch.

antongolub commented 3 years ago

@davikawasaki,

" This branch cannot be rebased due to conflicts Rebasing the commits of this branch on top of the base branch cannot be performed automatically due to conflicts encountered while reapplying the individual commits from the head branch. "

But I think this can be eliminated with squash anyway.

davikawasaki commented 3 years ago

@antongolub I might be facing some problems with rebase tbh. In case this doesn't resolve the merge conflict, I can recreate the PR from scratch.

davikawasaki commented 3 years ago

@antongolub added the combination as you've mentioned, as well as some docs. Now even codeclimate likes the code, so I'm happier :)

antongolub commented 3 years ago

@davikawasaki,

Merged! Thanks for the contribution and your patience.

qiwibot commented 3 years ago

:tada: This PR is included in version 3.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

antongolub commented 3 years ago

@davikawasaki,

Could you also bring this improvement to dhoulb/multi-semantic-release?

davikawasaki commented 3 years ago

@antongolub yeah, will pass this with the other PR that I've done in here.