Closed chawyehsu closed 2 years ago
Hey, @chawyehsu,
Reasonable improvement, thanks. But let's introduce slash
/unixify
helper: https://github.com/semrel-extra/topo/blob/master/src/main/ts/index.ts#L93
I could do. But what do you think I should put the slash
helper into which place? utils.js
? glob.js
? or the same palce getPackagePaths.js
.
I suggest utils.js
LGTM, thanks for the contribution. The release is on the way
:tada: This PR is included in version 3.17.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Great, could you update the semrel-toolkit dep to adopt the fix by the way?
Sure, I will.
Fix this well-known issue on Windows... upstream: https://github.com/sindresorhus/globby/issues/155
Passing Windows's backslash to globby/fast-glob will cause an empty return for workspacePackages.
https://github.com/qiwi/multi-semantic-release/blob/d83a6a729f31c8a1fcbd2720797b673781828bd2/lib/getPackagePaths.js#L38
Which leads to an error of
package.json: Project must contain one or more workspace-packages
.