search

qiwi / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
86 stars 34 forks source link

feature request: don't ignore private packages #66

Closed Talent30 closed 2 years ago

Talent30 commented 2 years ago

First of all, thank you for your awesome work!

Current behaviour: if package is set to private release will be skipped.

Desired behaviour: same as upstream if the package is set to private, release will not push the package to npm but still generate a release log.

Cheers

antongolub commented 2 years ago

Hey @Talent30,

Thanks for the feedback. It seems possible to introduce a new flag to control pkg filtering behaviour, however msr cannot disable a particular plugin like npm by design. But you can place a custom release config for your special private pkg, and include only the required plugins (example: https://github.com/qiwi/pijma/blob/master/packages/desktop/.releaserc.cjs).

qiwibot commented 2 years ago

:tada: This issue has been resolved in version 6.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

antongolub commented 2 years ago

@Talent30,

Try out v6.1.0

Talent30 commented 2 years ago

Much appreciated

From: Anton Golub @.> Sent: Friday, 1 April 2022 05:25 To: qiwi/multi-semantic-release @.> Cc: Talent30 @.>; Mention @.> Subject: Re: [qiwi/multi-semantic-release] feature request: don't ignore private packages (Issue #66)

@Talent30https://github.com/Talent30,

Try v6.1.0

— Reply to this email directly, view it on GitHubhttps://github.com/qiwi/multi-semantic-release/issues/66#issuecomment-1084814505, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADADGBMINL56NHYPLJVEJKDVCXGW5ANCNFSM5SFA3I7A. You are receiving this because you were mentioned.Message ID: @.***>