`--deps.bump=satisfy` not working as expected

[csantos-nydig]

Issue type

• [x] bug report
• [ ] idea
• [ ] question
• [ ] other

Expected behavior

multi-semantic-release --deps.bump=satisfy

Should respect the semver.satisfies ranges defined in our package.json

Actual behavior

multi-semantic-release --deps.bump=satisfy

Still behaves as override

• [x] I've read the docs. This case is not mentioned
• [x] Similar issue does not exist

Steps to reproduce

I don't have a full code example, but here is my setup:

monorepo with 2 repositories:

• @myapp/core
• @myapp/web

@myapp/web/package.json

"peerDependencies": {
    "@myapp/core": ">=1.0.0-beta.1"
}

When I execute: multi-semantic-release --deps.bump=satisfy, peerDependencies is still overwritten.

Specifications

• version: "@qiwi/multi-semantic-release": "3.17.1"
• platform: Mac
• ci: N/A - tested locally

Debugging

I debugged this library locally, and noticed the following:

• resolveNextVersion, 3rd parameter (strategy) is supposed to be "inherit", "override", "satisfy" https://github.com/qiwi/multi-semantic-release/blob/b7f9f69ff7c2a7f5c68027314bc312025c5ecdfb/lib/updateDeps.js#L234 https://github.com/qiwi/multi-semantic-release/blob/b7f9f69ff7c2a7f5c68027314bc312025c5ecdfb/lib/updateDeps.js#L239
• but it's been called from within getDependentRelease passing releaseStrategy ("patch", "minor", "major", "inherit") instead of bumpStrategy https://github.com/qiwi/multi-semantic-release/blob/b7f9f69ff7c2a7f5c68027314bc312025c5ecdfb/lib/updateDeps.js#L177-L178 https://github.com/qiwi/multi-semantic-release/blob/b7f9f69ff7c2a7f5c68027314bc312025c5ecdfb/lib/updateDeps.js#L196

[csantos-nydig]

dhoulb/multi-semantic-release seems to be passing the right prop, see:

• https://github.com/dhoulb/multi-semantic-release/blob/e8a86419a86d13f64692d923878a115b996aae77/lib/updateDeps.js#L228
• https://github.com/dhoulb/multi-semantic-release/blob/e8a86419a86d13f64692d923878a115b996aae77/lib/updateDeps.js#L308-L313

[EinfachHans]

is anyone fixing this? should i fix it? Guess it would be enough to call resolveNextVersion with the bumpStrategy instead of the releaseStrategy?

[qiwibot]

:tada: This issue has been resolved in version 7.1.1 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: