Closed csantos-nydig closed 10 months ago
dhoulb/multi-semantic-release
seems to be passing the right prop, see:
is anyone fixing this? should i fix it? Guess it would be enough to call resolveNextVersion
with the bumpStrategy
instead of the releaseStrategy
?
:tada: This issue has been resolved in version 7.1.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Issue type
Expected behavior
Should respect the
semver.satisfies
ranges defined in our package.jsonActual behavior
Still behaves as
override
Steps to reproduce
I don't have a full code example, but here is my setup:
monorepo with 2 repositories:
@myapp/core
@myapp/web
@myapp/web/package.json
When I execute:
multi-semantic-release --deps.bump=satisfy
,peerDependencies
is still overwritten.Specifications
"@qiwi/multi-semantic-release": "3.17.1"
Debugging
I debugged this library locally, and noticed the following:
resolveNextVersion
, 3rd parameter (strategy
) is supposed to be "inherit", "override", "satisfy" https://github.com/qiwi/multi-semantic-release/blob/b7f9f69ff7c2a7f5c68027314bc312025c5ecdfb/lib/updateDeps.js#L234 https://github.com/qiwi/multi-semantic-release/blob/b7f9f69ff7c2a7f5c68027314bc312025c5ecdfb/lib/updateDeps.js#L239getDependentRelease
passingreleaseStrategy
("patch", "minor", "major", "inherit") instead ofbumpStrategy
https://github.com/qiwi/multi-semantic-release/blob/b7f9f69ff7c2a7f5c68027314bc312025c5ecdfb/lib/updateDeps.js#L177-L178 https://github.com/qiwi/multi-semantic-release/blob/b7f9f69ff7c2a7f5c68027314bc312025c5ecdfb/lib/updateDeps.js#L196