search

qiwi / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
86 stars 34 forks source link

fix: don't touch packages with 'workspace' set as a package version #95

Open bartlomiejzuber opened 1 year ago

bartlomiejzuber commented 1 year ago

Fixes https://github.com/qiwi/multi-semantic-release/issues/87

Changes

It skips connected packages that has 'workspace' e.g. 'workspace:*' keyword set as version number.

antongolub commented 1 year ago

Hey @bartlomiejzuber,

By default semrel uses npm-plugin to publish packages. If we dont switch workspace:* ref to a specific version like 1.0.0 what happens next?

antongolub commented 1 year ago

Take a look on the upstream repo: https://github.com/dhoulb/multi-semantic-release/blob/b4e68f9ec42b166ff2e713c04a966b0fbecc9661/test/lib/updateDeps.test.js#L53

Smth similar is implemented there. Maybe it's possible to reuse this code.

zigang93 commented 2 months ago

@antongolub can you explain how to avoid this? my pnpm install failed due to 'workspace:*' keyword set as version number.