search

qiwi / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
86 stars 34 forks source link

fix: --deps.bump not working as expected #99

Closed csantos1113 closed 10 months ago

csantos1113 commented 10 months ago

Fixes #83

Changes

Use bumpStrategy instead of releaseStrategy when calling resolveNextVersion

antongolub commented 10 months ago

@csantos1113,

Nice catch! Thanks for the digging.

csantos1113 commented 10 months ago

@antongolub 😢 because this PR only had one commit, it seems github used that one (instead of the PR title)... and my commit message was wrong. So I'm not sure this will trigger a new release 😢

in fact it didn't trigger a new release: https://github.com/qiwi/multi-semantic-release/actions/runs/6616386710/job/17970551525

antongolub commented 10 months ago

My fault. I'll take care.

qiwibot commented 10 months ago

:tada: This PR is included in version 7.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

csantos1113 commented 10 months ago

My fault. I'll take care.

Thanks for fixing it 🙏 and sorry for not using semantic-release format for my commits 😓