fix: fix branches opt handling

qiwi / semantic-release-gh-pages-plugin

github-pages publishing plugin for semantic-release

MIT License

23 stars 8 forks source link

fix: fix branches opt handling #249

Closed antongolub closed 11 months ago

antongolub commented 11 months ago

Fixes #248

Changes

[x] New code is covered by tests
[x] All the changes are mentioned in docs (readme.md)

rb-mwindh commented 11 months ago

Just one question: in main/ts/config.ts#L173 you omit the branch and branches properties from the pluginConfig object. Why is that?

Just an assumption: if there's a potential naming clash with properties from context.options[step], wouldn't it be cleaner to rename those two properties (branch and branches)?

Anyway, thanks for the quick bugfix. I really appreciate your hard work 👍

antongolub commented 11 months ago

This is true. The naming collision came as a surprise to us and we just added a crutch. I think we can improve this impl part in the future. And PRs, of course, are always welcome.