search

qiwi / semantic-release-monorepo-hooks

Workarounds to handle `semantic-release-monorepo` multipublishing
MIT License
33 stars 4 forks source link

fix(deps): add explicit read-pkg and semver dependencies #6

Closed meatwallace closed 5 years ago

meatwallace commented 5 years ago

added explicit dependency mappings for read-pkg and semver which were previously being resolved from downstream dependencies. this prevents the build breaking if they were to be removed and allows compatibility with tooling that enforces a strict dependency graph ex. Yarn PnP.

meatwallace commented 5 years ago

hey there - ran into an issue when trying to use this package with Yarn's PnP feature that identified that read-pkg and semver were being used without being explicitly depended on. besides resolving that issue, although it's unlikely those downstream dependencies will go missing, this change eliminates that risk entirely.

let me know if you'd like any changes or more context.

cheers.

antongolub commented 5 years ago

@meatwallace Good catch! Thanks for the contribution.

qiwibot commented 5 years ago

:tada: This PR is included in version 2.9.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: