Both randomizers use forward slashes, which don't work on Windows

qixils / minecraft-randomiser

Resource pack and data pack randomiser to shuffle textures, sounds, loot tables, recipes, and more

MIT License

46 stars 6 forks source link

Both randomizers use forward slashes, which don't work on Windows #4

Closed vitalline closed 5 years ago

vitalline commented 5 years ago

Paths on Windows use backward slashes, not forward ones. This results in the resource randomizer working only partially and the data randomizer not working at all.

Alluseri commented 5 years ago

Windows is not picky on slashes. I don't know about Windows 10(not an autist, sorry), but in Windows 7 it is so.

vitalline commented 5 years ago

Well, I just checked. Under Windows 10, the randomizer doesn't recognize paths with forward slashes in them and, as a result, simply treats the folders as empty. Here is a "result" of me running the Datapack Randomizer on Win10 without any commandline arguments. (I tested it by changing the slashes to escaped backslashes, and it worked just fine.) random_data.zip

qixils commented 5 years ago

working on a patch rn

qixils commented 5 years ago

Hopefully fixed by https://github.com/noellekiq/minecraft-randomiser/commit/b44dc7ad879fd9d0ff30249d41ad1a502c891614 and https://github.com/noellekiq/minecraft-randomiser/commit/f4d1966cf82249a03ea744b4049272e4d695f9cb, if it's still broke then something else is wrong