qkitgroup / qkit

Qkit framework
GNU General Public License v2.0
43 stars 46 forks source link

cfg_local and cfg searched in config.local.py #45

Closed Schneider1 closed 6 years ago

Schneider1 commented 6 years ago

In our qkit/__init__.py we search for the following config arguments:

from qkit.config.local import cfg_local
# and later
from qkit.config.local import cfg as cfg_local

As we are only using the cfg variable in config.local, so I guess it should be fine to remove the import cfg_local part?

rotzinger commented 6 years ago

Well, no. In config/local.py there can be a definition of cfg = {} or cfg_local = {}. This depends how local.py was created. Originally local.py was a new file with the cfg_local = {} definition, we then introduced the possibility to just copy the environment.py into local.py and make changes there, which automatically means that cfg = {} is defined. So no action is needed.