Closed fr34q closed 6 years ago
I just scanned through the changes and found the following:
[ ] measure_td
: I don't see the point in the find_latest_file()
function. You could do it with a switch in the measure_3D_AWG
function or store the filename internally. Scanning through all files in the data dir is not the best solution here.
[ ] measure_td
: None
comparisons should be done with if z_unit is None:
instead of if z_unit == None:
due to the fact that the variable could be an array. This is not acutally relevant here, but I suggest to use the is
comparison throughout the code.
[ ] timedomain/initialize.py
: In my opinion, the code should still work for the old way and for different setups, so please introduce a kind of switch that allows to distinguish between different setups and to fully restore the old behavior.
Pull request to track changes relative to master branch.
Feature ist still in development so do not merge!