search

qkitgroup / qkit

Qkit framework
GNU General Public License v2.0
43 stars 46 forks source link

cfg['load_visa'] in local.py_template #51

Closed mpfirrmann closed 6 years ago

mpfirrmann commented 6 years ago

With commit ed3438c, 'cfg['load_visa']=True' in the environment template. This means I would have to explicitly comment out this command before being able to start up qkit on an analysis computer. This is somewhat contradictory to the commit message and a little bit counter intuitive. Is this a bug or a feature?

Schneider1 commented 6 years ago

I could not find anything wrong in the commit you mentioned.

I guess you mean c6e8e0cb4510909f96781fd2a9193e597a5892ba instead. I agree that the commit message looks contradictory in the first place, but before this commit, qkit tried to detect whether visa is available. So you did not have to set cfg['load_visa'] explicitly. Unfortunately this had some drawbacks and worked not too well. Now with this commit, the default is cfg['load_visa'] = False. So putting cfg['load_visa'] = False in the local.py makes no sense. One could argue that it should be commented out, but this is only a template file. The idea is not that you just blindly copy the file to your local.py, but you should carefully go through the settings you make there.