ql-io / ql.io-site

The source for the ql.io project site
http://ql.io
Other
13 stars 8 forks source link

Fix: twitter search error. #5

Closed shigeki closed 12 years ago

shigeki commented 12 years ago

Example of twitter search in the example page was failed as below because the offset parameter is missing. I add the offset parameter as 2 in the example and also put uri.removeEmptyParams() in twitter.js to work even when the offset or other parameters are missing.

http://ql.io/console?s=select%20id%20as%20id%2C%20from_user_name%20as%20user%2C%20text%20as%20text%0A%20%20from%20twitter.search%20where%20q%20%3D%20%22ql.io%22%20limit%205

{

"headers": {
    "content-type": "application/json"
},
"body": {
    "error": "Invalid parameter"
}

}

shimonchayim commented 12 years ago

Thanks for looking into this reviewing your pull request.

s3u commented 12 years ago

Thanks for the catch.

shigeki commented 12 years ago

Is the reason why this is closed because my patch are not accepted after your code review?

s3u commented 12 years ago

Oops - wrong button.

shigeki commented 12 years ago

Thanks for merge. Never mind. I've ever used to do it before.