qld-gov-au / ckanext-data-qld

Queensland Government Open Data extension
GNU Affero General Public License v3.0
1 stars 6 forks source link

QOLSVC-2117, QOLDEV-455, reCAPTCHA added, multiple CHDEXCHAE privacy enhancements #207

Closed duttonw closed 1 year ago

duttonw commented 1 year ago

Lots of changes (please include pr body in merge message)

QOLSVC-2117 CHDEXCHAE-64 CHDEXCHAE-62 CHDEXCHAE-61 CHDEXCHAE-60 CHDEXCHAE-59 CHDEXCHAE-67 CHDEXCHAE-56 QOLDEV-455

QOLSVC-2041CHDEXCHAE-62

https://github.com/DataShades/ckanext-data-qld/pull/3

Acceptance criteria

In the Additional Info and Additional Information tables on Datasets and Resources respectively, replace ‘Field name '[fieldname]' not in data’ with [blank] where no value is stored.

QOLSVC-2039CHDEXCHAE-61

https://github.com/qld-gov-au/ckanext-resource-visibility/pull/10 https://github.com/DataShades/ckanext-data-qld/pull/4

Acceptance criteria

The existing helptext “Privacy assessment information, including the meaning of the Privacy assessment result, can be found here.” is changed to “Refer to the linked Privacy Assessment Report for details of the assessment.”

“Privacy Assessment Report“ isw linked toteh same URL as the “here“ in the current helptext

the help text was added in CHDEXCHAE-14: 5.12 Add new resource metadata field for edit resource (privacy assessment result) :CKAN:COMPLETED ON DEV

QOLSVC-2040CHDEXCHAE-60

https://github.com/qld-gov-au/ckanext-resource-visibility/pull/11 https://github.com/DataShades/ckanext-data-qld/pull/5

Description

Provide a visible indicator for a resource to show publishers that it is hidden from the public

Current behaviour

Resources in the hidden state currently appear, to those with the appropriate access level to see them, the same as other visible resources within the dataset

Acceptance criteria

When a resource is saved with a resource_visibility value of 'FALSE'

Then the resource is visually differentiated to indicate that this resource is not visible to the public and other unauthorised users AND when the resource is selected and displayed

Then the resource includes the same label/flag/indicator to remind the publisher/user that this is a hidden resource

this looks exactly as the “Private“ dataset label on the dataset search page, but says “HIDDEN“ (instead of “PRIVATE“)

this affects both Dataset page (list of resources with the label in the front of the resource title) AND resource preview page (the label in the front of the resource title)

The tests are added/updated accordingly

QOLSVC-2077CHDEXCHAE-59

https://github.com/DataShades/ckanext-data-qld/pull/6
https://github.com/qld-gov-au/ckanext-resource-visibility/pull/12

Description

Hide any resource when privacy assessment is requested irrespective of the dataset's contains deidentified data value.

Current behaviour

Only resources within datasets that have a contains de-identified data value of 'YES' are hidden when a privacy assessment value of 'YES' is saved

Acceptance criteria

The logic is updated to check only for a single value:

When a privacy assessment is requested (request_privacy_assessment value of 'YES' saved) for a resource - any resource,

then the resource_visibility value is saved as 'FALSE'

And the resource is hidden from public view

Being visible only to editor-level users and above (including Sysadmin users) within the organisation specified in the dataset metadata

Existing tests are updated

QOLSVC-2078CHDEXCHAE-67

https://github.com/DataShades/ckanext-data-qld/pull/7 https://github.com/qld-gov-au/ckanext-resource-visibility/pull/14

Description

Hide the Request privacy assessment field and value in the resource Additional information for users below Editor level (Member, General, not logged in)

Current behaviour

The Request privacy assessment field and value (when blank or 'NO' with a dataset contains de-identified data value of YES - the resource is hidden if YES, and always with a dataset contains de-identified data value of NO) is visible to all users in the resource Additional information.

Acceptance criteria

The Request privacy assessment field and value should only be displayed in the resource Additional information when the user level is Editor and Admin for the organisation recorded in the dataset metadata or Sysadmin level

The Request privacy assessment field and value should only be displayed to API users with a key for a profile at level is Editor and Admin for the organisation recorded in the dataset metadata or Sysadmin level

Other