qld-gov-au / qgds-bootstrap5

MVP development space for Queensland Government Design System (QGDS) Bootstrap 5 implementation, Dist folder located in https://github.com/qld-gov-au/qgds-qol-mvp-release
https://qld-gov-au.github.io/qgds-bootstrap5/
2 stars 3 forks source link

[QOLOE-192]Update select input based on design QA. #253

Closed elvishu closed 2 weeks ago

elvishu commented 2 weeks ago

Minor styling changes on Select input from Design QA: https://ssq-qol.atlassian.net/browse/QOLOE-192

duttonw commented 2 weeks ago

Please also fix hardcoded selection options in HBS file. This should have already been picked up in uat testing except i don't believe its in use. https://github.com/qld-gov-au/qgds-bootstrap5/blob/develop/src/components/bs5/select/select.hbs#L31

elvishu commented 2 weeks ago

Sounds good @duttonw. In order to keep this PR clear and focused, I will fix the hardcoded options in a separate PR under ticket QOLOE-191. Please approve this PR if you see fit.