search

qligier / angular4-events

Events is a publish-subscribe style event system based on sqlProvider/angular2-pubsub
7 stars 4 forks source link

Throws "Cannot redeclare block-scoped variable 'ngDevMode'" in angular 6 #4

Closed RezDev94 closed 6 years ago

RezDev94 commented 6 years ago

I just updated my angular to 6 and now i have this error:

image

When in remove angular4-events from ng.modules.ts, it works fine.

qligier commented 6 years ago

Hey, Can you try with the new version (npm install --save angular4-events@5.0.1)? It should fix issues with Angular 6 but I still haven't had time to upgrade my own projects, so feedback would be appreciated.

boehlerlukas commented 6 years ago

@qligier thank's for this repo! Its a great lib! Just tested to upgrade to 5.0.1 but the error still occurs.

boehlerlukas commented 6 years ago

@qligier it seems like buid 5.0.0 did work for me, but 5.0.1 didn't. (sorry was on angular5)

qligier commented 6 years ago

Yep, version 5.0.1 is only compatible with Angular 6, I should have named it v6.0.0. The README has been updated to clarify that.

qligier commented 6 years ago

Closing this issue as it should have been fixed with v5.0.1 update.

OlehRb commented 6 years ago

@qligier Hi there, I am having the same issue, but using 5.0.1 doesn't help. I tried to install your library through yarn and npm, but none of the attempts finished successfully. My angular version is 6.0.3, angular4-events version is 5.0.1.

Is there something else I can do about it or am I missing something?

OlehRb commented 6 years ago

@qligier, hmm, I guess it is issue with yarn, because initially I installed some of modules through it and they worked fine, but your module even on 5.0.1 still gave the same error. Unfortunately installing your module through npm somehow removed some modules, which were previously installed using yarn. Finally, I dropped _nodemodules/ folder, did npm i and I don't get this error anymore.

It would be awesome if you check why installing of your module on version 5.0.1 using yarn fails. Also, thanks for an awesome library)

qligier commented 6 years ago

Hey, glad you were able to get it working and thank you for investigating the issue. I have never used yarn, I'll test it when I have the time.