search

qlik-demo-team / qdt-components

React Components to be used with Angular 10, React 16 and Vue 2. Connects with the Capability API and Engine API.
MIT License
92 stars 50 forks source link

Adding own components #9

Closed dreadeyedave closed 6 years ago

dreadeyedave commented 6 years ago

Hi,

I am trying to add my own components / make amendments to existing ones, e.g. the qdtFilter can only be named 'Dropdown'.

Please can you help/advise me on the best way to do that? Would I need an object wrapper as per the method in the repo https://github.com/fkabinoff/qlik-react-starter?

Thanks D

dreadeyedave commented 6 years ago

and would that be the Qdt-components.jsx in components?

yianni-ververis commented 6 years ago

Yes that would be it but we are not sure if renaming the component is the right approach.

You can recompile in your local repo with any naming convention you want. Just type npm start and use the dist folder.

dreadeyedave commented 6 years ago

Hi Yianni,

Thanks - I figured out the structure and have a version that is running uncompiled so that I can dev my own components. Have made changes to the Filter so that it now takes a title, happy to contribute, although I am sure you guys could make that change if you wanted it.

Cheers

yianni-ververis commented 6 years ago

You can definitely contribute and we encourage that. Please commit and do a pull request.

Just do not change the component name.

yianni-ververis commented 6 years ago

And thank you for your contribution