fix: return GenericVariable for Get/Create Variable methods

qlik-oss / enigma-go

Go library for consuming Qlik's Associative Engine.

MIT License

39 stars 12 forks source link

fix: return GenericVariable for Get/Create Variable methods #191

Closed aihazm closed 3 years ago

aihazm commented 3 years ago

Previously, Create/Get Variable methods were returning Variable type those methods should return a GenericVariable instead

Note: the GetMeasureWithLabel method was also returning the wrong type Generic instead of GenericMeasure

This is a breaking change for :

CreateSessionVariable
GetVariable
GetVariableById
CreateVariableEx and
GetMeasureWithLabel

aihazm commented 3 years ago

Lets create a backlog item for improving how these return-types are handled. Preferably enough information should be included in the Open-RPC spec to determine the return type.

@wennmo FTR: https://github.com/qlik-oss/enigma-go/issues/192