qlik-oss / enigma-go

Go library for consuming Qlik's Associative Engine.
MIT License
39 stars 12 forks source link

Fix go.mod for major version release v2 #196

Closed wennmo closed 3 years ago

wennmo commented 3 years ago

The v2 major release of enigma-go also required some changes to go.mod that was not part of the release.

The following intake failed for core-using-licenses: https://github.com/qlik-oss/core-using-licenses/pull/160

Command failed: docker run --rm --name=renovate_go --label=renovate_child -v "/mnt/renovate/gh/qlik-oss/core-using-licenses":"/mnt/renovate/gh/qlik-oss/core-using-licenses" -v "/tmp/renovate-cache":"/tmp/renovate-cache" -v "/tmp/renovate-cache/others/go":"/tmp/renovate-cache/others/go" -e GOPATH -e CGO_ENABLED -w "/mnt/renovate/gh/qlik-oss/core-using-licenses" docker.io/renovate/go:1.16.4 bash -l -c "git config --global url.\"https://**redacted**@github.com/\".insteadOf \"https://github.com/\" && go get -d ./... && go mod tidy && go mod tidy"
go: github.com/qlik-oss/enigma-go/v2@v2.0.0: go.mod has non-.../v2 module path "github.com/qlik-oss/enigma-go" (and .../v2/go.mod does not exist) at revision v2.0.0

According to golang module docs a major release should include: https://golang.org/doc/modules/major-version