search

qlik-oss / enigma-go

Go library for consuming Qlik's Associative Engine.
MIT License
39 stars 12 forks source link

fix: Improve context handling #243

Closed glooms closed 2 years ago

glooms commented 2 years ago

This simplifies how the default-dialer works by removing the functionality for context-cancelling on the enigma-end. The package we're using for websockets and their dependencies (the standard libraries net and net/http) use contexts correctly.

The simplification also ensures that the context is passed correctly with DialContext which enables the use of httptrace.ClientTrace - a valuable tool for debugging.