search

qlik-oss / enigma.js

JavaScript library for consuming Qlik's Associative Engine.
MIT License
210 stars 82 forks source link

fix: response parameters for StoreTempSelectionState #941

Closed niekvanstaveren closed 2 years ago

niekvanstaveren commented 2 years ago

StoreTempSelectionState only returns a boolean when called because in includes the qReturn key. It should return the qId instead. Engine cannot update this because it will be a breaking API change

niekvanstaveren commented 2 years ago

I have no history/background, on why we choose to do those exceptions in enigma.js instead of having them outside

Engine cannot update this because it will be a breaking API change

FTR this change is breaking for the client lib anyway

Not the first time this happens: https://github.com/qlik-oss/enigma.js/pull/55 From an API perspective yes this would be breaking. However I don't think anyone is using this function at the moment as it would be impossible to get any value out of it without this change.

I guess since the methods in this interceptor would all be unusable without these adaptations it was done in enigma.