Closed simonmcmillan closed 1 year ago
Hi, and thanks for contributing!
Note: If you are part of Qlik R&D, you can apply to the open-source
team in our internal GitHub organization, and ignore the rest of these instructions.
Before we can handle your pull request we need you to sign our contributor license agreement. This is a one-time process and enables you to contribute without hassle to any of the qlik-oss repositories in the future.
And it only takes a few minutes! Here are some useful links to get you started:
Having troubles? Feel free to reach out to us either here or on Slack!
Note: Once the CLA is sorted, you should rebase/touch this pull request to trigger an update of this CLA status.
Hi @simonmcmillan, (apologies for the delay...) could you please rebase on master, we are trying to figure out why the CI builds are failing
Hi @simonmcmillan Even though red, we will merge the PR - the build fails due to cross-forks secrets sharing (we are not able to allow sharing secrets across forks due to obvious security reasons) - thank you for the patience
Awesome thankyou!
With our implementation of Enigma we hit a snag where the resolver can be undefined.
This fix ensures that if the resolver is undefined Enigma wont crash.