Closed diptanw closed 5 years ago
Hi, and thanks for contributing!
Note: If you are part of Qlik R&D, you can ignore this process (but let us know in a comment below!)
Before we can handle your pull request we need you to sign our contributor license agreement. This is a one-time thing and enables you to contribute without hassle to any of the qlik-oss repositories in the future.
And it only takes a few minutes! Here are some useful links to get you started:
Having troubles? Feel free to reach out to us either here or on Slack!
This PR was submitted by the Qlik R&D member @diptanw
@diptanw - Could you provide a more detailed description of what problem this PR solves. Background, context etc, perhaps with an example of what can now be handled which was not previously possible?
If the
bson
tag has more than just a key in its value (for example, additional flags, such asomitempty
), thefindStructFieldNameByBsonTag()
function cannot find the corresponding field name when generating a cursor for a given paginated field. As a result, the application crashes when trying to get the field value.This PR enables to use an additional bson tag flags without panicing, by parsing the tag and handling the errors.