qlik-oss / qmfe-actions

0 stars 0 forks source link

Investigate why creating PRs doesnt fail the workflow #132

Closed egilsster closed 1 year ago

egilsster commented 2 years ago

https://github.com/qlik-oss/qmfe-actions/blob/v1/update-qmfe-import-map/src/index.ts#L47

This should fail the workflow, or at least that is what we want.

LiKang6688 commented 2 years ago

why do we separate qmfe-workflows and qmfe-actions and one in qlik-trial and another one in qlik-oss?

egilsster commented 2 years ago

why do we separate qmfe-workflows and qmfe-actions and one in qlik-trial and another one in qlik-oss?

When we started this project it wasn't possible to re-use private actions. Now that we can, we could potentially just consolidate these into to our internal repo.