search

qlik-oss / server-side-extension

A Qlik server-side extension protocol for extending the Qlik built-in expression library with functionality from external calculation engines.
MIT License
155 stars 126 forks source link

Dangerous function call #51

Open djo-it opened 4 years ago

djo-it commented 4 years ago

Hi,

I've found some little issues in your example code. At

https://github.com/qlik-oss/server-side-extension/blob/c500be88a47c3ec35b6b798d20b9867f9761211c/examples/cpp/basic_example/basic_example.cc#L126

and

https://github.com/qlik-oss/server-side-extension/blob/c500be88a47c3ec35b6b798d20b9867f9761211c/examples/cpp/basic_example/basic_example.cc#L167

In this case it would be more safe to use the ParseFromArray function because the data can contain zero bytes which will result in a parse error. This caused some problems in our sse because we are evaluating the metadata.

Kind regards, Daniel John