qlik-oss / server-side-extension

A Qlik server-side extension protocol for extending the Qlik built-in expression library with functionality from external calculation engines.
MIT License
155 stars 126 forks source link

Replace deprecated append method with concat #58

Open hurrifan1 opened 1 year ago

hurrifan1 commented 1 year ago

Replaced the deprecated and recently removed Dataframe.append() method with the recommended Pandas.concat(). Dataframe.append() has been deprecated for a while and was removed in the most recent Pandas 2.0.0 release. See Pandas issue here.

There was not an existing issue for this, let me know if I should make one first for tracking purposes.

Status

[ ] Under development
[X] Waiting for code review
[ ] Waiting for merge

Information

[ ] Contains breaking changes
[ ] Contains new API(s)
[ ] Contains documentation
[ ] Contains test
[ ] Contains examples

To-do list

No todos

qlikossbuild commented 1 year ago

Hi, and thanks for contributing!

Note: If you are part of Qlik: follow the process outlined on the internal developer portal instead. Reach out to open-source@qlik.com if you do not have access to that developer portal.


Before we can handle your pull request we need you to sign our contributor license agreement. This is a one-time process and enables you to contribute without hassle to any of the qlik-oss repositories in the future.

And it only takes a few minutes! Here are some useful links to get you started:

Having troubles? Feel free to reach out to us either here or on Slack!

Note: Once the CLA is sorted, you should rebase/touch this pull request to trigger an update of this CLA status.