search

qlik-oss / sn-action-button

Action button supernova for nebula.js
https://qlik.dev/libraries-and-tools/visualizations/action-button
MIT License
4 stars 8 forks source link

feat: enabled chart tab for button object along with maintaining backward compatibility of properties #339

Closed rajani-varpe closed 1 year ago

rajani-varpe commented 1 year ago

This PR intends to enable the chart tab in button object along with backward compatibility of editor properties except the background Image using Media Library.

Background Image using Media Library is working fine in Styling Panel, the action item to get this working with backward compatibility is to add the correct condition in MediaLibrary component. This functionality works fine with "args.properties" (MediaLibrary Component)but later this has been changed to "args.handler.layout.component" which tend to fail as we do not have any "components" in style editor.

So this condition needs to be handled to get this working properly.

1. Styling Panel

image

2. Style Editor - without FF

image

3. Styling Panel - with FF

image
Donya-qlik commented 1 year ago

@AmeliaAndersson @LiKang6688 @niekvanstaveren Could you please start reviewing this PR? I'll take care of this PR since the responsible person is not working with Qlik anymore. Thanks!

Note: Rajani has mentioned in his explanations that Media Library is not working with args.layout.properties. I'm not sure I understood what he meant. Media Library works properly in sense-client as an extension as far as I tested it. Let me know if you have any idea about it. Thanks.