search

qlik-oss / sn-action-button

Action button supernova for nebula.js
https://qlik.dev/libraries-and-tools/visualizations/action-button
MIT License
4 stars 8 forks source link

chore: set unit test threshold #360

Closed niekvanstaveren closed 1 year ago

cbt1 commented 1 year ago

Looks like this PR is also changing the coverage :oops:, so you might want to update the config file to either include only relevant src files or at least exclude the jest config file

cbt1 commented 1 year ago

I wonder where coveralls gets that new coverage number from? Look at the coverage reported generated during the build does not produce any that would result in that number from what I can tell

niekvanstaveren commented 1 year ago

I wonder where coveralls gets that new coverage number from? Look at the coverage reported generated during the build does not produce any that would result in that number from what I can tell

No me neither. I'm gonna play a bit locally with this before merging. See if I can get this correct

niekvanstaveren commented 1 year ago

I wonder where coveralls gets that new coverage number from? Look at the coverage reported generated during the build does not produce any that would result in that number from what I can tell

It ended up adding some files to the coverage I think that were not included before. Added some to the excluded path that were only containing constants.

EDIT: I also don't know where this number is coming from. Looking at the page it does not show where the decrease is coming from either. I think we can ignore this for now.