qlik-oss / sn-action-button

Action button supernova for nebula.js
https://qlik.dev/libraries-and-tools/visualizations/action-button
MIT License
4 stars 8 forks source link

fix: remove unsupported softLock actions #404

Closed johanlahti closed 1 year ago

johanlahti commented 1 year ago

Remove actions which do no work with softLock (the checkbox label suggests that they should overwrite locked fields, but this does not work, which is also in accordance with Engine design).

I have gone through all actions and found that it works only for the following actions. For others I have removed the checkbox:

The same has been done in sense-client for sheet actions and this PR will make them aligned.

Before:

image

After (soft lock removed):

image
haxxmaxx commented 1 year ago

We probably need to change here https://help.qlik.com/en-US/cloud-services/Subsystems/Hub/Content/Sense_Hub/Visualizations/Button/create-buttons.htm

johanlahti commented 1 year ago

@haxxmaxx I have contacted @tklkan to update the docs. To be completely aligned, I guess we should do this when this has been merged, released and bumped in sense-client – but since the functionality is broken, it's "almost ok" if it's removed from the docs before that's done.