search

qlik-oss / sn-action-button

Action button supernova for nebula.js
https://qlik.dev/libraries-and-tools/visualizations/action-button
MIT License
4 stars 8 forks source link

fix: use fullscreen flag to disable fullscreen support #420

Closed vatharic closed 1 year ago

vatharic commented 1 year ago

Use newly created fullscreen support prop to disable fullscreen support for this chart. fullscreen support prop added here: https://github.com/qlik-trial/sense-client/pull/25161

Used by new line object (sn-shape) like so https://github.com/qlik-trial/sn-shape/pull/148

The prop removes the fullscreen option from the nav menu and the context menu.

Will create PR in sense-client to remove hardcoded checks for action-button and instead rely on the fullscreen support prop

Also changing booleans to actual booleans for readability.

qlikossbuild commented 1 year ago

:tada: This PR is included in version 1.37.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: