fix: button background image is missing in the downloaded sheet

qlik-oss / sn-action-button

Action button supernova for nebula.js

https://qlik.dev/libraries-and-tools/visualizations/action-button

MIT License

4 stars 8 forks source link

fix: button background image is missing in the downloaded sheet #421

Closed Donya-qlik closed 1 year ago

Donya-qlik commented 1 year ago

Issue:

Downloading sheet includes button with background image, results a button without background image in preview window

Solution:

Defining a promise to wait for the image to be loaded in the background before setting the image url as the background-image. It prevents the button from reporting to the reporting service while the image is loading.

Donya-qlik commented 1 year ago

@haxxmaxx I retested my solution and seems the bug is still there! I was careful to keep the testing environment clean for each test and I couldn't reproduce it anymore for at least for a day but yesterday it showed up again! :( Not sure what might be the case, I think the solution waits enough for the image to be loaded.

haxxmaxx commented 1 year ago

@haxxmaxx I retested my solution and seems the bug is still there! I was careful to keep the testing environment clean for each test and I couldn't reproduce it anymore for at least for a day but yesterday it showed up again! :( Not sure what might be the case, I think the solution waits enough for the image to be loaded.

Yeah there probably needs to be something on the downloading side waiting for the button to finish rendering. Not sure how other charts do that actually.

qlikossbuild commented 1 year ago

:tada: This PR is included in version 1.37.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: