search

qmacro / thinking-aloud

A journal, of sorts.
13 stars 0 forks source link

2021-04-07 16:27:58 One consequence of using repo issues for journal e… #18

Open qmacro opened 3 years ago

qmacro commented 3 years ago

One consequence of using repo issues for journal entries is that it's quite open.

I just noticed that someone has added an issue (#14) recently and I'm currently not quite sure how I feel about it. The content of the issue is innocuous enough, and I think on balance I currently like how open things are. I've made efforts in the mechanics to guard against this sort of thing in that issues that are not created by me are not going to trigger any sort of update or processing.

In the workflow (which is triggered when an issue is created or updated), there are two jobs, generate (generate the feed and recent content flow) and tweet (tweet that there's a new entry).

The generate job has an if condition like this:

if: github.actor == github.repository_owner && contains(github.event.issue.labels.*.name, 'entry')

This checks that the actor (the person involved in the event that triggered the workflow) is the same person as the repository_owner, in other words, me. It also checks that the issue has the entry label (see #9 as to why this is).

The second job, tweet, also has an if condition, like this:

if: github.event.action == 'opened'

This ensures that a tweet is only sent when an issue is created, not also if it's updated.

But the tweet job also has this:

needs: generate

Which means that tweet only runs if generate completes successfully. Which in turn implies that generate's checks also apply here, indirectly.

That's good enough for me for now.

I'm still not sure how I want to proceed with this external issue. I'll have to think about it. It's a chance for engagement, but perhaps I should just automatically delete them. Let's see.

rsletta commented 3 years ago

I was actually thinking of this scenario, when working on my setup. I came to the conclusion that as long as the safe guards do their jobs, and prevent publication, all interactions (as long as they're not hostile) are well intended and an invitation for a conversation. While I don't think I'm exposed enough to get any traffic in my repo, and the subject of my setup not as inviting as yours, I plan to handle it with moderation and a new tag for sorting.

qmacro commented 3 years ago

Yes, I think you're right @rsletta - that's how I was leaning yesterday, and having slept on it, I've reached the same conclusion.