search

qmateub / gatsby-source-nba

Source plugin for pulling NBA data into Gatsby 🏀
3 stars 3 forks source link

feat(config-options): Add option for season start year #6

Closed tvthatsme closed 5 years ago

tvthatsme commented 5 years ago

I didn't forget about this 😅

Here's the config option for the season start year.

Defaults to the start year of the build. So if no seasonStart is provided today it would be 2019. Let me know if this makes sense to you and I can add the documentation as well.

Note: I did remove the filter of if the player had played that year because it was filtering out everything for me. Do we really need this?

tvthatsme commented 5 years ago

Cool. Am I right in seeing that the image is just a url? I have something in progress too that does the create remote file node so that the images can be used with gatsby-image

qmateub commented 5 years ago

Cool. Am I right in seeing that the image is just a url? I have something in progress too that does the create remote file node so that the images can be used with gatsby-image

Yes @tvthatsme ! Currently is just an url, I also had something prepared for converting that into a gatsby-image but never finished it. Feel free to open a PR for adding that and we can take a look 👀

Thanks a lot!