search

qmathe / DropDownMenuKit

UIKit drop down menu, simple yet flexible and written in Swift
Other
303 stars 38 forks source link

Centering text + image #16

Closed rico237 closed 7 years ago

rico237 commented 7 years ago

Depending on text size the collapse image and text are not centered ...

simulator screen shot 25 juil 2017 a 01 25 09 simulator screen shot 25 juil 2017 a 01 25 07 simulator screen shot 25 juil 2017 a 01 25 04

qmathe commented 7 years ago

Hi,

Thanks for the bug report, I'm going to take a look at it.

ashleyhenderson commented 7 years ago

I'm having a similar error, where if the initial title text is longer than the next chosen option - the new title appears off-centre as pictured image1 1 image1

ashleyhenderson commented 7 years ago

Do you happen to have an ETA on a fix for this?

EDIT: Apologies! I just checked your code here and our version doesn't incorporate your fix 2 months ago for this issue. Can confirm your most recent GitHub version fixes the bug. It's quite strange as we installed 2 days ago via cocoapods but seem to have picked up the wrong version!

qmathe commented 7 years ago

Yes, this issue has already been fixed in master with cbd130a.

I just committed an extra fix to ensure the title is correctly centered, even when you don't call DropDownMenu.selectMenuCell() while creating the menu.

I'm going to make another CocoaPods release, the current one is quite outdated now.

ashleyhenderson commented 7 years ago

Fantastic! The updated cocoapods release would be much appreciated 🙂

qmathe commented 7 years ago

Just pushed the new 0.8.3 release to CocoaPods!