qmatic / api-gateway

The Orchestra REST API gateway
MIT License
1 stars 0 forks source link

Version and behavior mismatch in start and stop script. #14

Closed kripe closed 3 years ago

kripe commented 4 years ago

Reported against version 1.4.8.0

The start script (api-gateway) does this to figure out a suitable JDK:

if [ -d "$APP_HOME/jre1.8.0_192" ]; then
    JAVA_HOME="$APP_HOME/jre1.8.0_192"
    chmod u+x $JAVA_HOME/bin/*
fi

I.e. checks for the presence of the jdk folder and sets the JAVA_HOME accordingly.

The stop script (api-gateway-stop.sh) does this instead, which not only resets any previously set JAVA_HOME, but also points to a different version:

if [ "Linux" == `uname` ]
then
    export JAVA_HOME=$GW_HOME/jre1.8.0_72
    export PATH=$JAVA_HOME/bin:$PATH

    JPS=$JAVA_HOME/bin/jps
else
    JPS=`which jps`
fi

The start and script should:

kripe commented 3 years ago

Fixed by Robert L - commits https://github.com/qmatic/api-gateway/commit/3abddae481d1334286a19ce405743b6dadf30a09 and https://github.com/qmatic/api-gateway/commit/f78ef15326d16c81972ec98a57cfe5dd6c8f0f69