search

qmc2 / qmc2-mame-fe

QMC2 - M.A.M.E. Catalog / Launcher II
41 stars 3 forks source link

request: build with history.xml #34

Closed ghost closed 7 months ago

ghost commented 8 months ago

Hi

Could you please release a new build (in the tags on github) that has history.xml support included? I want to test it and report possible bugs. I'm not familiar with compiling qmc2...

belegdol commented 8 months ago

I do not have sufficient rights to make a release, but please try this out: https://github.com/belegdol/qmc2-mame-fe/actions There is an artifact for ubuntu-22.04/x86_64, macos-14/aarch64 and macos-12/x86_64.

ghost commented 8 months ago

Windows not possible? Since this project is not maintained, isn't it better you make a fork so you have all rights? In that way you can make qmc2 alive again

belegdol commented 8 months ago

I am trying to get windows running as we speak. Technically there is a fork since I need one for the PRs. Having said that, I can realistically only fix small things.

ghost commented 8 months ago

That's more then enough! I think nobody is committing anything anymore.

belegdol commented 8 months ago

Yes, the lead developer unfortunately passed away last year.

ghost commented 8 months ago

Yes, the lead developer unfortunately passed away last year.

I know :(

Can you also upgrade the project to QT6 or is that too difficult? It would be awesome to have a fresh start with QT6.

belegdol commented 8 months ago

I think updating to qt-6 might be beyond my coding skills unfortunately.

belegdol commented 8 months ago

Looks like there is no msys QtWebEngine for Windows, so no Windows builds are possible from git master. Sorry.

ghost commented 8 months ago

Looks like there is no msys QtWebEngine for Windows, so no Windows builds are possible from git master. Sorry.

How was the previous build made then? You can find here 2 windows builds.

https://github.com/qmc2/qmc2-mame-fe/tags

ghost commented 8 months ago

Anybody maybe knows how the 2 Windows builds here were made then?

belegdol commented 8 months ago

Switch to qtwebengine was made after 0.243. Before that qtwebkit was used, for which msys package is available. For qtwebengine the build would need to be made with msvc. I will have a look if this can be done.

ghost commented 8 months ago

Switch to qtwebengine was made after 0.243. Before that qtwebkit was used, for which msys package is available.

I don't know much about QT, but why was the switch made and for what particular widget in QMC2 is qtwebengine used? Is it for the tabpages that display a webpage?

belegdol commented 8 months ago

QtWebKit is no longer maintained and full of security issues. As for what it is used for, notes tab is one example. I will look into possible solutions but it is going to take some time. I can maybe make a 0.243+fixes branch over at my fork in the meantime.

belegdol commented 8 months ago

Very preliminary windows build: https://github.com/belegdol/qmc2-mame-fe/actions/runs/7966316077/job/21747346457 Uses ancient qr 5.15.2 because this is what is available prebuilt.

ghost commented 8 months ago

Latest QT 5 not possible? I read somewhere QT 5 is close to become abandoned. So will the linux and mac build suffer from this too? I hope somebody can update the project to QT6

belegdol commented 8 months ago

Well Qt5 beyond 5.15.2 are only distributed as source. So instead of just downloading it as it is done currently, Qt would need to be built from source first, which would burn through the 2000 minutes available for free in no time (or 2000 minutes really) - if it even were enough to build heavy dependencies like qtwebengine more than a handful of times.

ghost commented 7 months ago

What free minutes are you talking about?

belegdol commented 7 months ago

https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#included-storage-and-minutes

It might actually be entirely free for public repos after all, I am not sure. It does not matter in the end. I use Linux myself and I just getting qmc2 to build with msvc has been difficult enough already. Effectively becoming a msvc Qt package maintainer is not something I have the time or interest for. Sorry.

cuavas commented 7 months ago

There are per-user resource limits, but you can’t see how close to hitting the limit you are. If you exceed the limits, your account can be flagged for “abuse” and you will be unable to trigger GitHub Actions CI jobs, even for your pull requests against other projects. This has happened to MAME contributors (e.g. @0kmg). It’s particularly easy to hit the storage limit for workflow artefacts with large projects if you aren’t careful.

There’s no appeal process, and they won’t even tell you what limits you exceeded. They justify this by saying if they told you what the limits are, you could try to sidestep them.

Some users associated with “halo projects” are exempt from the limits. There’s no way of knowing whether your account is exempt from limits (besides generating enough workflow artefacts to exceed the normal limits and seeing if you get banned).

It’s very opaque, and you need to tread carefully if you depend on being able to run CI jobs.