search

qmd-lab / closeread

https://closeread.dev
MIT License
128 stars 5 forks source link

Issue 135: increase mobile breakpoint for sidebar layouts #138

Closed jimjam-slam closed 8 hours ago

jimjam-slam commented 1 week ago

7f4bcf2 makes the structural change here, setting a breakpoint for sidebar layouts one step up the Bootstrap breakpoint ladder (to 768px).

In 6b6832b, I've adjusted the sidebar width in both gallery examples to minmax(320px, 1fr) (in Auden it was minmax(400px, 1fr); in Minard it was 1fr).

I actually think this is a much better default for all users — would you be okay with me changing the CSS custom property default as part of this PR, @andrewpbray?

andrewpbray commented 1 week ago

Nice, this is an improvement!

One this I noticed: the width of the overlay narrative col is the full window instead of the narrative col on a demo that is native.overlay-center.

Screenshot 2024-11-11 at 8 49 52 AM Screenshot 2024-11-11 at 8 49 08 AM

Is this the bit of .overlay-center that we want to propagate up to the media query?

Screenshot 2024-11-11 at 8 54 05 AM
jimjam-slam commented 1 week ago

Thanks @andrewpbray, have fixed that! Ready to merge if you're otherwise happy with it 😊

andrewpbray commented 1 week ago

Great - I'm happy!